From 2f87adf68b3c95aeb06dd7980665198d70ff02c8 Mon Sep 17 00:00:00 2001 From: millert <> Date: Mon, 3 May 2004 20:53:34 +0000 Subject: [PATCH] Be smarter about signed vs. unsigned (produces better error messages). OK otto@ --- src/lib/libc/stdlib/strtonum.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/libc/stdlib/strtonum.c b/src/lib/libc/stdlib/strtonum.c index 9ac0d34e..a7f07c90 100644 --- a/src/lib/libc/stdlib/strtonum.c +++ b/src/lib/libc/stdlib/strtonum.c @@ -1,4 +1,4 @@ -/* $OpenBSD: strtonum.c,v 1.1 2004/05/03 17:09:24 tedu Exp $ */ +/* $OpenBSD: strtonum.c,v 1.2 2004/05/03 20:53:34 millert Exp $ */ /* * Copyright (c) 2004 Ted Unangst and Todd Miller * All rights reserved. @@ -48,7 +48,7 @@ strtonum(const char *numstr, long long minval, unsigned long long maxval, if (minval > maxval || maxval < minval || (minval < 0 && maxval > LLONG_MAX)) error = INVALID; - else if (minval >= 0) { + else if (maxval > LLONG_MAX ) { ull = strtoull(numstr, &ep, 10); if (numstr == ep || *ep != '\0') error = INVALID;