From 775ea3cbc95ad1438808c30958588f7501e57354 Mon Sep 17 00:00:00 2001 From: kn <> Date: Sun, 18 Feb 2018 21:48:00 +0000 Subject: [PATCH] zap *_path() functions These PATH helpers failed to quote their input properly leading to shell code execution. Noone noticed since import (over 21 years ago), so wipe it. OK tb rpe --- src/etc/ksh.kshrc | 25 +------------------------ 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/src/etc/ksh.kshrc b/src/etc/ksh.kshrc index 5b5bd040..5230b8ff 100644 --- a/src/etc/ksh.kshrc +++ b/src/etc/ksh.kshrc @@ -1,4 +1,4 @@ -# $OpenBSD: ksh.kshrc,v 1.30 2017/11/05 10:58:39 rpe Exp $ +# $OpenBSD: ksh.kshrc,v 1.31 2018/02/18 21:48:00 kn Exp $ # # NAME: # ksh.kshrc - global initialization for ksh @@ -119,26 +119,3 @@ case "$-" in *) # non-interactive ;; esac -# commands for both interactive and non-interactive shells - -# is $1 missing from $2 (or PATH) ? -function no_path { - eval _v="\$${2:-PATH}" - case :$_v: in - *:$1:*) return 1;; # no we have it - esac - return 0 -} -# if $1 exists and is not in path, append it -function add_path { - [[ -d ${1:-.} ]] && no_path $* && eval ${2:-PATH}="\$${2:-PATH}:$1" -} -# if $1 exists and is not in path, prepend it -function pre_path { - [[ -d ${1:-.} ]] && no_path $* && eval ${2:-PATH}="$1:\$${2:-PATH}" -} -# if $1 is in path, remove it -function del_path { - no_path $* || eval ${2:-PATH}=$(eval echo :'$'${2:-PATH}: | - sed -e "s;:$1:;:;g" -e "s;^:;;" -e "s;:\$;;") -}