From dcb69a238499c43e0c41ca48fe517e9fc5fbce7c Mon Sep 17 00:00:00 2001 From: sthen <> Date: Fri, 7 Aug 2009 22:27:47 +0000 Subject: [PATCH] - specifically match carp+([0-9]):, not just carp*:. avoids spurious attempts to "ifconfig carp down" noticed by david@. - use non-descriptive variables names rather than $if/$junk to encourage people reading the code to think what it's doing; many of the output lines are not interface names. ok david@ --- src/etc/rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/etc/rc b/src/etc/rc index 3864b2cc..959d0b98 100644 --- a/src/etc/rc +++ b/src/etc/rc @@ -1,4 +1,4 @@ -# $OpenBSD: rc,v 1.330 2009/08/05 02:06:21 deraadt Exp $ +# $OpenBSD: rc,v 1.331 2009/08/07 22:27:47 sthen Exp $ # System startup script run by init on autoboot # or after single-user. @@ -166,9 +166,9 @@ if [ X"$1" = X"shutdown" ]; then echo /etc/rc.shutdown complete. # bring carp interfaces down gracefully - ifconfig | while read if junk; do - case $if in - carp*:) ifconfig ${if%:} down ;; + ifconfig | while read a b; do + case $a in + carp+([0-9]):) ifconfig ${a%:} down ;; esac done