dhartmei
cef62f0908
re-enable function pointer table protection, this time make sure that
malloc.c gets the first mmap() call (since it depends on that, for its
sbrk(0) use). ok deraadt@
22 years ago
deraadt
f73c2b1c58
do not export error_table
22 years ago
miod
6819b734ce
Suggest better types in examples; from NetBSD
22 years ago
millert
ca00f6f3e4
mark pw_error() __dead since it exits
22 years ago
dhartmei
3e0b53c913
Back it out, it breaks something in perl (seen with spamassassin), debug
first.
22 years ago
deraadt
968c135966
permit calloc(0, N) and calloc(N, 0) -- malloc(0) does the right thing; markus miod ok
22 years ago
deraadt
08616e9a96
return failure if integer overflow happens. sigh; too people had to
help get this right.
22 years ago
dhartmei
b7839b1965
Replace atexit handler. mprotect() the pages so an attempt to modify the
function pointers from the outside will segfault. Idea, hints and feedback
from deraadt. ok deraadt.
22 years ago
millert
3a97f67ea7
Convert to ANSI function headers and make 'ch' argument int, not char.
Noticed by deraadt@
22 years ago
millert
8605e7d157
Replace strtou?q() with the more standard strtou?ll(), using weak
aliases to fake up strtou?q(). espie@ OK.
22 years ago
deraadt
695e261e2d
%u for uid/gid; millert ok
22 years ago
millert
b013f0d14d
Now that we don't have a trailing newline we need to explicitly check
that the first char in the line is not NUL after killing comments.
22 years ago
millert
6cea6780f6
Use strtok_r() instead of strsep() since the latter treats consecutive
field separators as empty field. This is not what we want for
whitespace-delimited fields.
22 years ago
millert
fab5e38f3f
login_fbtab(3) fixes:
o make first arg const since we don't modify it
o use strsep() instead of strtok() as strtok() changes internal state
o add some bounds checking and use strlcat() instead of pointer arithmetic
o ANSI function headers
Originally based on a patch from Lars J. Buitinck but much modified.
22 years ago
fgsch
fb18813faf
some -Wall and spaces cleanup, scsi.c left.
some brave soul should look at it.
22 years ago
deraadt
f1eab69159
unsigned vs unsigned int
22 years ago
deraadt
1861c91a56
pid_t cleanup
22 years ago
deraadt
9f44aaa017
strlcpy at most 16 characters, so says man page
22 years ago
deraadt
5cdc7e2335
strlcpy and KNF
22 years ago
deraadt
23c67c2ee8
KNF
22 years ago
deraadt
7c4d34d5bc
try to use strlcpy and snprintf more; ok various
22 years ago
itojun
19f3ad7a81
atexit(3) can fail. handle error accordingly. deraadt ok
XXX libraries should not use atexit(3) from within, as program can terminate
with _exit.
22 years ago
millert
d67b87ef2f
For strncpy(), dst is not NUL terminated if strlen(src) >= len.
Also fix a typo; adapted from a patch by Moritz Jodeit
22 years ago
mpech
bc299477ad
o) start new sentence on a new line;
o) always close .Bl tags;
o) fix usage of .Xr;
millert@ ok
22 years ago
mpech
93a232f650
Initial cleanup:
o) remove extra space in the end of line;
o) remove extra blank lines in the end of file;
o) remove .Pp before .Ss;
o) CAVEAT -> CAVEATS;
o) fix usage of .Fa;
o) <blank-line> -> .Pp;
o) wrap long lines;
millert@ ok
22 years ago
pvalchev
5ca0ee4656
wierd -> weird
22 years ago
mpech
c68a3ac420
Clean up after pw_file().
millert@ ok
deraadt@ ok to commit
22 years ago
pvalchev
849e52ae81
mdoc fixes from pjanzen
23 years ago
pvalchev
8da612ea6c
rephrase warning; from miod
23 years ago
pvalchev
18eb0e3fca
print a warning that realpath points to internal static storage space that
will be overwritten by subsequent calls; suggested by pjanzen, ok millert
23 years ago
miod
fba1d2eff0
deraadt@ objects to the caveat remark, so remove it.
23 years ago
miod
2e6a70b044
Slightly improve wording and punctuation.
23 years ago
miod
b796301032
Add a caveat section pointing out that people affecting the return value
of getopt() to char variables instead of int lose on arches where char is
unsigned by default.
Clean the example by not pasting parts of <unistd.h> into it, and by not
using atoi(3).
23 years ago
deraadt
893d09ec7a
fgsch, if you commit without test compiling ONE MORE TIME, I will send a castration team down to argentina
23 years ago
fgsch
265d2ab100
use sizeof w/ defines; niklas@ millert@ ok.
23 years ago
millert
d0f45c1a97
We live in an ANSI C world. Remove lots of gratuitous #ifdef __STDC__ cruft.
23 years ago
mpech
1d113f7a3f
login_close() should avoid memory leak.
millert@ ok
23 years ago
millert
959b08f109
Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)
23 years ago
millert
b68c09e067
Part one of userland __P removal. Done with a simple regexp with some minor hand editing to make comments line up correctly. Another pass is forthcoming that handles the cases that could not be done automatically.
23 years ago
mickey
df85ac99b5
fix the history refs
23 years ago
fgsch
f9ed61c293
THREAD_UNLOCK() on error before returning; millert@ ok.
23 years ago
marc
a1df4e69bd
compile sparc64 version of sha1.go with -O0, too. OK jason@
23 years ago
millert
1e2fd73b66
Use the volatile specifier to fix warnings about variables being
clobbered by longjmp / vfork instead of the gcc "(void)&foo;" hack.
23 years ago
millert
b6c954318e
If the user passes in "" as the string to resolve the lstat() will
fail anyway so check for that. Also convert "." to "" since that
way we avoid the lstat() (which we don't need) and the subsequent
chdir() and some dir checks.
23 years ago
mpech
a0ba08a5ce
pids should be pid_t, not int
23 years ago
miod
f782f2c5fe
Two functions can return errors here, not just one.
23 years ago
deraadt
2ebe322d0c
when strerror() has an Unknown error, also set EINVAL
23 years ago
deraadt
b7edc160a2
save the pid as well, and only do the atexit in the same pid
23 years ago
deraadt
7e48f32113
alloca cannot check if the allocation is valid. mention the consequences; millert ok
23 years ago
tdeval
77a7c73d5c
correct an alignment mis-conception for malloc(0) returned regions.
OK deraadt@
23 years ago