deraadt
855ec93ea1
adapt to bitstring(3) renaming, and look at that bit_ffs(3) is the actual
name we want to Xr...
ok jmc
4 years ago
deraadt
fd9d083e20
uucplock(3) is incorrectly named in some places, it is actually uu_lock(3)
(more unclear is if anything in ports uses this, as our base no longer does)
4 years ago
martijn
742a87c636
Revert previous. There were some users of the quirky behaviour that were
missed during code scan.
4 years ago
martijn
9a09cc0ee9
Fix argument list for ber_set_writecallback
OK claudio@
4 years ago
jmc
f057789eb2
wonky comma;
4 years ago
martijn
e78f6151d9
Document that ber_scanf_elements' 'p' and 't' attribute don't eat the
current ber element.
OK claudio@
Seems sensible to deraadt@
4 years ago
martijn
8eab0e4153
Make ber_scanf_elements's 'e' attribute eat the element.
Right now all consumers use 'e' at the end of the list, so no regressions
should be introduced.
OK claudio@
Seems sensible to deraadt@
4 years ago
martijn
89ee3aeaf4
Make sure that ber in ber_scanf_elements is not NULL before parsing format
where ber is utilized. This also allows us to remove the ber->be_next
check, which can cause weird behaviour, because a NULL be_next would result
in parsing the last element twice.
OK claudio@ on previous version
OK rob@
4 years ago
martijn
738a1a7927
Don't use a 0 element to determine the end of an OID when comparing two
OIDS. This can result in false equality matches.
OK claudio@
4 years ago
martijn
0802062d3c
There's no reason why the first digit of an OID can't be 0.
OK claudio@
"Good find" deraadt@
4 years ago
deraadt
b52d602999
correct mispellings of EACCES; from Kris Katterjohn
4 years ago
dtucker
08a2eaba0f
Fix comment typo; from OpenSSH Portable
5 years ago
inoguchi
84248221bb
Using pthread_atfork instead of __register_atfork with uClibc on noMMU
uClibc on noMMU doesn't provide __register_atfork().
Reported by redbirdtek on Github issue.
https://github.com/libressl-portable/portable/issues/538
ok bcook@
5 years ago
deraadt
ac61f7141b
improve verb-tense for explaining the calling convention of __
ok guenther jmc
5 years ago
deraadt
e4c1e3b43b
The last consumer of pre-posix realpath behaviour has stopped
requiring it (sftp-server).
Remove the /exists///// behaviour from here. The /nonexistant
behaviour remains in the kernel and needs to be shot next.
There may be ports fallout, but we doubt it.
ok beck djm
5 years ago
deraadt
74b2c8400a
snprintf/vsnprintf return < 0 on error, rather than -1.
5 years ago
jmc
ae687bf577
tweak previous; ok guenther
5 years ago
guenther
5ecede4ab7
Document that getcwd() and realpath() are built on system calls that
have a different calling convention than the standard function...as seen
in kdump output.
ok deraadt@ schwarze@
5 years ago
schwarze
c3832ee06f
Actually, the C standard only guarantees that atexit(3) returns non-zero
on error, so tweak previous to test "atexit(...) != 0" for portability.
"OK ok ok sorry backwards" deraadt@
5 years ago
deraadt
e5e55cd690
When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
5 years ago
deraadt
ebbe8d8121
atexit() returns -1 on failure
5 years ago
schwarze
3f543536a9
The C89 standard only requires that atexit(3) returns a non-zero value
on error, so checking for -1 only is potentially non-portable.
Also mention that the C89 standard does not require errno to be set.
OK deraadt@ millert@
5 years ago
deraadt
dc26ca4789
Remove old realpath(3), and the userland-vs-kernel realpath verification
code. We now user the simple userland wrapper on top of __realpath(2).
The non-POSIX behaviour still remains, that is the next component to fix.
From a diff by beck, but I managed to chainsaw it a bit further. Tested
in snaps for a couple of days.
ok beck
5 years ago
jmc
a00849e337
oops - missing .El in previous;
5 years ago
deraadt
04e8452164
realpath(3) doesn't use lstat(2), readlink(2), or getcwd(3) anymore,
it is a thin wrapper over the syscall __readlink(2). Improve the list
of possible errors.
ok millert beck jmc
5 years ago
dtucker
340e9dca9e
Cast bitcount to u_in64_t before bit shifting to prevent integer overflow
on 32bit platforms which cause incorrect results when adding a block
>=512M in size. sha1 patch from ante84 at gmail.com via openssh github,
sha2 with djm@, ok tedu@
5 years ago
guenther
dd9a969523
Complete the ld.so boot cleanup: move most libc initialization from
_csu_finish() to _libc_preinit(), which is an .init_array function
in shared libc (and mark it INITFIRST) or a .preinit_array function
in static libc, grabbing the _dl_cb callback there from ld.so. Then
in _csu_finish(), invoke the dl_clean_boot() callback to free ld.so's
startup bits before main() gets control.
Other cleanups this permits:
- move various startup structures into .data.rel.ro
- the dl* stubs in libc can be strong and call the callbacks provided
via _dl_cb
- no longer need to conditionalize dlctl() calls on presence of _DYNAMIC
original concept and full diff ok kettenis@
ok deraadt@
5 years ago
rob
9d258bd6e0
Limit maximum number of length octets to platform independent sizeof(int32_t).
Problem noticed by bluhm@. Discussed on hackers.
ok claudio@
5 years ago
deraadt
6d85d2cced
__realpath(2) appears to have improved, so re-enable the code that
checks userland-parsing vs kernel parsing, we are hoping to spot another
bug..
5 years ago
deraadt
8517992d0e
There are some bugs in __realpath(2) -- it isn't quite ready so disable
calling it until those are fixed.
5 years ago
beck
ee8781d936
Enable the use of the kernel __realpath() system call in the libc wrapper.
For now, this also still uses the existing realpath implmentation
and emits a syslog if we see differening results. Once we have run
with that for a little while we will remove the old code
ok deraadt@
5 years ago
otto
f5de0f5c27
Only override size of chunk if we're not given the actual length.
Fixes malloc_conceal...freezero with malloc options C and/or G.
5 years ago
rob
5ea11244b8
whitespace
5 years ago
rob
459d3403bc
Cleanup some residual markup from the ber.3 days.
ok jmc@, schwarze@
5 years ago
schwarze
48f8f2e845
clarify that later flags modify earlier flags;
triggered by a question from Jan Stary <hans at stare dot cz> on misc@;
OK otto@
5 years ago
schwarze
f6ecccdd17
add various missing information
and remove the lie that these functions would set errno;
tweaks and OK jmc@; OK rob@ on the previous version
5 years ago
rob
509ea037e6
Add XXX to a comment.
5 years ago
rob
8e14404ce3
Correct errno markup. Noticed by schwarze.
Discussed with schwarze and jmc. ok schwarze
5 years ago
schwarze
c39a22b840
More consistently put remarks about the less useful LC_* categoties,
i.e. those other than LC_CTYPE, into the CAVEATS section, and
standardize wording somewhat.
OK jmc@
5 years ago
jmc
e2a13c2289
sort SEE ALSO;
5 years ago
schwarze
a870edacf8
add substantial amounts of missing information;
OK rob@
5 years ago
rob
4a2c8d4050
Consistently make errno a .Vt
5 years ago
schwarze
1786209d57
delete two stray blank lines
5 years ago
schwarze
0b50432670
delete some duplicate words
5 years ago
rob
b43f7ed0ff
Split ber.3 into logical parts. Further tweaking will be done in tree.
Discussed with and ok jmc@, schwarze@, claudio@
5 years ago
otto
afee62df16
Mention introduction of *_conceal.
5 years ago
rob
b02b4b32b0
Enable support for the writting of BITSTRING by treating it as an OCTETSTRING.
ok claudio@
5 years ago
rob
b6f67bd097
Enforce smallest number of contents octets for int (and enum).
ok claudio@
5 years ago
rob
f90a0d7af2
Mention #include of <sys/types.h> in synopsis.
Discussed with claudio@ and tedu@.
5 years ago
rob
cbfc875695
Fail early if a (universal) primitive type identifies as constructed, or if a
boolean has a contents length other than 1.
ok claudio@
5 years ago