style: come lint fixes

app/src/main/res/layout/dialog_link.xml

@@ -18,8 +18,8 @@
         android:id="@+id/etLink"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:text="https://email.faircode.eu/"
+        android:text="@string/default_link"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/tvOpenLink" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/fragment_about.xml

@@ -22,7 +22,7 @@
             android:id="@+id/tvVersion"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="Version 1.0"
+            android:text="@string/default_version"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toBottomOf="@id/tvName" />

app/src/main/res/layout/fragment_account.xml

@@ -47,7 +47,7 @@
             android:id="@+id/etDomain"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="domain.tld"
+            android:hint="@string/default_hint_domain"
             android:inputType="textUri"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -113,7 +113,7 @@
             android:id="@+id/etHost"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="imap.domain.tld"
+            android:hint="@string/default_hint_imap"
             android:inputType="textUri"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -153,7 +153,7 @@
             android:id="@+id/etPort"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="993"
+            android:hint="@string/default_imap_port"
             android:inputType="number"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -331,7 +331,7 @@
             android:id="@+id/etInterval"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="19"
+            android:hint="@string/default_interval"
             android:inputType="number"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"

app/src/main/res/layout/fragment_folder.xml

@@ -96,7 +96,7 @@
             android:id="@+id/etAfter"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="7"
+            android:hint="@string/default_sync"
             android:inputType="number"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -142,4 +142,4 @@
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent" />
     </androidx.constraintlayout.widget.ConstraintLayout>
-</ScrollView>
+</ScrollView>

app/src/main/res/layout/fragment_identity.xml

@@ -143,7 +143,7 @@
             android:id="@+id/etDomain"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="domain.tld"
+            android:hint="@string/default_hint_domain"
             android:inputType="textUri"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -197,7 +197,7 @@
             android:id="@+id/etHost"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="smtp.domain.tld"
+            android:hint="@string/default_hint_smtp"
             android:inputType="textUri"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -239,7 +239,7 @@
             android:id="@+id/etPort"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:hint="465"
+            android:hint="@string/default_smtp_port"
             android:inputType="number"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintStart_toStartOf="parent"
@@ -367,4 +367,4 @@
             android:layout_height="0dp"
             app:constraint_referenced_ids="tvEmail,etEmail,tvReplyTo,etReplyTo,tvProvider,spProvider,tvDomain,etDomain,btnAutoConfig,tvSmtp,tvInsecure,tvHost,etHost,cbStartTls,tvPort,etPort,tvUser,etUser,tvPassword,tilPassword,cbSynchronize,cbPrimary,cbStoreSent" />
     </androidx.constraintlayout.widget.ConstraintLayout>
-</ScrollView>
+</ScrollView>

app/src/main/res/layout/item_account.xml

@@ -38,7 +38,7 @@
         android:layout_marginStart="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Medium"
         app:layout_constraintBottom_toBottomOf="@id/ivPrimary"
         app:layout_constraintEnd_toStartOf="@+id/ivSync"
@@ -60,7 +60,7 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
         android:layout_marginStart="6dp"
-        android:text="user"
+        android:text="@string/default_user"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintEnd_toStartOf="@+id/ivSync"
         app:layout_constraintStart_toEndOf="@+id/ivPrimary"
@@ -84,7 +84,7 @@
         android:layout_marginStart="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="host"
+        android:text="@string/default_host"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintBottom_toBottomOf="@id/ivState"
         app:layout_constraintEnd_toEndOf="parent"
@@ -97,7 +97,7 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
         android:layout_marginStart="6dp"
-        android:text="error"
+        android:text="@string/default_error"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         android:textColor="?attr/colorWarning"
         app:layout_constraintEnd_toEndOf="parent"
@@ -118,4 +118,4 @@
         android:background="?attr/colorSeparator"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/marginBottom" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_answer.xml

@@ -13,7 +13,7 @@
         android:layout_marginTop="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Medium"
         app:layout_constraintEnd_toStartOf="@+id/tvSize"
         app:layout_constraintStart_toStartOf="parent"
@@ -28,4 +28,4 @@
         android:background="?attr/colorSeparator"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/tvName" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_attachment.xml

@@ -30,7 +30,7 @@
         android:layout_marginStart="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintBottom_toBottomOf="@id/ivAttachments"
         app:layout_constraintEnd_toStartOf="@+id/tvSize"
@@ -42,7 +42,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginStart="6dp"
-        android:text="10 kB"
+        android:text="@string/default_attachment_size"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintBottom_toBottomOf="@id/ivAttachments"
         app:layout_constraintEnd_toStartOf="@+id/ivStatus"
@@ -74,7 +74,7 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginStart="6dp"
-        android:text="text/plain"
+        android:text="@string/default_attachment_type"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintEnd_toEndOf="@id/ivStatus"
         app:layout_constraintStart_toEndOf="@id/ivAttachments"
@@ -89,4 +89,4 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/tvType" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_drawer.xml

@@ -25,9 +25,9 @@
         android:gravity="center_vertical"
         android:maxLines="1"
         android:minHeight="?android:attr/listPreferredItemHeightSmall"
-        android:text="Menu item"
+        android:text="@string/default_menu_item"
         android:textAppearance="?android:attr/textAppearanceListItemSmall"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintStart_toEndOf="@id/ivItem"
         app:layout_constraintTop_toTopOf="parent" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_folder.xml

@@ -28,7 +28,7 @@
             android:ellipsize="start"
             android:gravity="center_vertical"
             android:singleLine="true"
-            android:text="Name"
+            android:text="@string/default_name"
             android:textAppearance="@style/TextAppearance.AppCompat.Medium"
             app:layout_constraintEnd_toStartOf="@+id/tvAfter"
             app:layout_constraintStart_toEndOf="@id/ivState"
@@ -40,7 +40,7 @@
             android:layout_height="24dp"
             android:layout_marginEnd="6dp"
             android:gravity="center_vertical"
-            android:text="123"
+            android:text="@string/default_messages_count"
             android:textAppearance="@android:style/TextAppearance.Small"
             app:layout_constraintEnd_toStartOf="@+id/ivMessages"
             app:layout_constraintTop_toTopOf="parent" />
@@ -76,7 +76,7 @@
             android:layout_height="24dp"
             android:layout_marginStart="6dp"
             android:gravity="center_vertical"
-            android:text="type"
+            android:text="@string/default_type"
             android:textAppearance="@android:style/TextAppearance.Small"
             app:layout_constraintStart_toEndOf="@id/ivUnified"
             app:layout_constraintTop_toBottomOf="@id/barrier1" />
@@ -87,7 +87,7 @@
             android:layout_height="24dp"
             android:layout_marginEnd="6dp"
             android:gravity="center_vertical"
-            android:text="30"
+            android:text="@string/default_interval"
             android:textAppearance="@android:style/TextAppearance.Small"
             app:layout_constraintEnd_toStartOf="@+id/ivSync"
             app:layout_constraintTop_toBottomOf="@id/barrier1" />
@@ -114,7 +114,7 @@
             android:layout_height="wrap_content"
             android:layout_marginStart="6dp"
             android:layout_marginEnd="6dp"
-            android:text="error"
+            android:text="@string/default_error"
             android:textAppearance="@style/TextAppearance.AppCompat.Small"
             android:textColor="?attr/colorWarning"
             app:layout_constraintEnd_toEndOf="parent"
@@ -132,4 +132,4 @@
             app:layout_constraintTop_toBottomOf="@id/tvError" />
 
     </androidx.constraintlayout.widget.ConstraintLayout>
-</FrameLayout>
+</FrameLayout>

app/src/main/res/layout/item_identity.xml

@@ -23,7 +23,7 @@
         android:layout_marginStart="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Medium"
         app:layout_constraintBottom_toBottomOf="@+id/ivSync"
         app:layout_constraintEnd_toStartOf="@+id/ivSync"
@@ -46,7 +46,7 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
         android:layout_marginStart="6dp"
-        android:text="user"
+        android:text="@string/default_user"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintEnd_toStartOf="@+id/ivSync"
         app:layout_constraintStart_toEndOf="@+id/ivPrimary"
@@ -69,7 +69,7 @@
         android:layout_marginStart="6dp"
         android:ellipsize="end"
         android:maxLines="1"
-        android:text="host"
+        android:text="@string/default_host"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintBottom_toBottomOf="@id/ivState"
         app:layout_constraintEnd_toStartOf="@+id/tvAccount"
@@ -82,7 +82,7 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
         android:layout_marginStart="6dp"
-        android:text="account"
+        android:text="@string/default_account"
         android:textAlignment="textEnd"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintBottom_toBottomOf="@id/ivState"
@@ -96,7 +96,7 @@
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
         android:layout_marginStart="6dp"
-        android:text="error"
+        android:text="@string/default_error"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         android:textColor="?attr/colorWarning"
         app:layout_constraintEnd_toEndOf="parent"
@@ -112,4 +112,4 @@
         android:background="?attr/colorSeparator"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/tvError" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_log.xml

@@ -10,7 +10,7 @@
         android:layout_height="wrap_content"
         android:ellipsize="start"
         android:singleLine="true"
-        android:text="12:34:56"
+        android:text="@string/default_timelog"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
@@ -20,9 +20,9 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginStart="6dp"
-        android:text="log"
+        android:text="@string/default_log"
         android:textAppearance="@android:style/TextAppearance.Small"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toEndOf="@id/tvTime"
         app:layout_constraintTop_toTopOf="parent" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/item_operation.xml

@@ -11,7 +11,7 @@
         android:layout_width="50dp"
         android:layout_height="wrap_content"
         android:layout_marginStart="6dp"
-        android:text="Msg#"
+        android:text="@string/default_msg"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
@@ -21,7 +21,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginStart="6dp"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintStart_toEndOf="@id/tvMessage"
         app:layout_constraintTop_toTopOf="parent" />
@@ -31,8 +31,8 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginEnd="6dp"
-        android:text="Time"
+        android:text="@string/default_time"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/spinner_dropdown_item.xml

@@ -6,6 +6,6 @@
     android:layout_height="?android:attr/listPreferredItemHeightSmall"
     android:ellipsize="marquee"
     android:singleLine="true"
-    android:text="Title"
+    android:text="@string/default_title"
     android:textAppearance="@style/TextAppearance.AppCompat.Medium"
     android:textColor="?android:textColorPrimary" />

app/src/main/res/layout/spinner_item.xml

@@ -6,7 +6,7 @@
     android:layout_height="wrap_content"
     android:ellipsize="marquee"
     android:singleLine="true"
-    android:text="Title"
+    android:text="@string/default_title"
     android:textAlignment="inherit"
     android:textAppearance="@style/TextAppearance.AppCompat.Medium"
     android:textColor="?android:textColorPrimary" />

app/src/main/res/layout/spinner_item2.xml

@@ -10,7 +10,7 @@
         android:id="@android:id/text1"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Name"
+        android:text="@string/default_name"
         android:textAppearance="@style/TextAppearance.AppCompat.Medium"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
@@ -19,8 +19,8 @@
         android:id="@android:id/text2"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="Email"
+        android:text="@string/default_email"
         android:textAppearance="@style/TextAppearance.AppCompat.Small"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@android:id/text1" />
-</androidx.constraintlayout.widget.ConstraintLayout>
+</androidx.constraintlayout.widget.ConstraintLayout>

app/src/main/res/layout/widget.xml

@@ -10,7 +10,8 @@
     <ImageView
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:paddingRight="@dimen/widget_padding"
+        android:paddingStart="@dimen/padding_xs"
+        android:paddingEnd="@dimen/padding_md"
         android:layout_gravity="center_horizontal"
         android:src="@drawable/ic_action_name"
         android:tint="@color/colorWidgetForeground" />
@@ -20,7 +21,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_gravity="center_horizontal"
-        android:text="--"
+        android:text="@string/default_count"
         android:textColor="@color/colorWidgetForeground"
         android:textSize="15sp"
         android:textStyle="bold" />

app/src/main/res/values/default.xml

@@ -0,0 +1,29 @@
+<?xml version='1.0' encoding='UTF-8'?>
+<resources>
+  <string name="default_count" translatable="false">--</string>
+  <string name="default_email" translatable="false">Email</string>
+  <string name="default_name" translatable="false">Name</string>
+  <string name="default_title" translatable="false">Title</string>
+  <string name="default_version" translatable="false">Version 1.0</string>
+  <string name="default_time" translatable="false">Time</string>
+  <string name="default_timelog" translatable="false">12:34:56</string>
+  <string name="default_log" translatable="false">log</string>
+  <string name="default_msg" translatable="false">Msg#</string>
+  <string name="default_user" translatable="false">User</string>
+  <string name="default_host" translatable="false">Host</string>
+  <string name="default_type" translatable="false">Type</string>
+  <string name="default_account" translatable="false">Account</string>
+  <string name="default_error" translatable="false">Error</string>
+  <string name="default_interval" translatable="false">19</string>
+  <string name="default_hint_domain" translatable="false">domain.tld</string>
+  <string name="default_hint_imap" translatable="false">imap.domain.tld</string>
+  <string name="default_hint_smtp" translatable="false">smtp.domain.tld</string>
+  <string name="default_imap_port" translatable="false">993</string>
+  <string name="default_smtp_port" translatable="false">465</string>
+  <string name="default_link" translatable="false">https://framagit.org/dystopia-project</string>
+  <string name="default_sync" translatable="false">7</string>
+  <string name="default_attachment_size" translatable="false">10 kB</string>
+  <string name="default_attachment_type" translatable="false">text/plain</string>
+  <string name="default_menu_item" translatable="false">Menu item</string>
+  <string name="default_messages_count" translatable="false">120</string>
+</resources>

app/src/main/res/values/dimens.xml

@@ -1,8 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <dimen name="base_margin">12dp</dimen>
+    <dimen name="padding_xs">3dp</dimen>
+    <dimen name="padding_md">6dp</dimen>
     <dimen name="layout_margin">12dp</dimen>
-    <dimen name="widget_padding">6dp</dimen>
     <dimen name="content_margin">6dp</dimen>
     <dimen name="compose_padding">6dp</dimen>
     <dimen name="input_height">40dp</dimen>